[
https://issues.apache.org/jira/browse/ARTEMIS-3137?focusedWorklogId=559974&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-559974
]
ASF GitHub Bot logged work on ARTEMIS-3137:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 02/Mar/21 14:13
Start Date: 02/Mar/21 14:13
Worklog Time Spent: 10m
Work Description: gemmellr commented on a change in pull request #3466:
URL: https://github.com/apache/activemq-artemis/pull/3466#discussion_r585597559
##########
File path:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/JMSXPathSelectorTest.java
##########
@@ -0,0 +1,162 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.activemq.artemis.tests.integration.amqp;
Review comment:
I disagree it would need any significant refactoring of the parents to
move the test class, as I dont think the parents need moved at all for the very
small thing I am suggesting of putting the class in the package most
appropriate for it. Not every parent needs to be in the same package, they
often arent.
Everything in the multiprotocol package is already parented by [different]
classes outwith that package. I dont think theres a requirement they all share
the same parent, but that could certainly be done if there was a desire and
sufficient benefit. I would agree that would come later as its a very distinct
task, separate from my comments.
Looking at moving e.g. the existing selector test class now, it looks like
it might only need either adding the word public to the ConnectionSupplier
interface definition, or maybe creating its own file...or even just removing it
since we could probably use java.util.function.Supplier. Presumably the classes
already in other packages dont use that interface.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 559974)
Time Spent: 6h 10m (was: 6h)
> Support XPath filters
> ---------------------
>
> Key: ARTEMIS-3137
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3137
> Project: ActiveMQ Artemis
> Issue Type: New Feature
> Reporter: Justin Bertram
> Assignee: Justin Bertram
> Priority: Major
> Time Spent: 6h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
