[
https://issues.apache.org/jira/browse/ARTEMIS-3285?focusedWorklogId=594169&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-594169
]
ASF GitHub Bot logged work on ARTEMIS-3285:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 10/May/21 18:43
Start Date: 10/May/21 18:43
Worklog Time Spent: 10m
Work Description: jbertram commented on a change in pull request #3569:
URL: https://github.com/apache/activemq-artemis/pull/3569#discussion_r629596410
##########
File path:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/JMSNonDestructiveTest.java
##########
@@ -588,4 +594,82 @@ private void sendLVQTombstone(ConnectionSupplier
producerConnectionSupplier, Str
producer.send(message1, javax.jms.Message.DEFAULT_DELIVERY_MODE,
javax.jms.Message.DEFAULT_PRIORITY, tombstoneTimeToLive);
}
}
+
+ @Test
+ public void testMultipleLastValuesCore() throws Exception {
+ testMultipleLastValues(CoreConnection);
Review comment:
I used the `ConnectionSupplier` because that's what all the other tests
in the class use and I find that consistency helps readability. I wouldn't
necessarily mind removing the `ConnectionSupplier` altogether, but it's used in
around 80 other places so that change is beyond the scope of this PR. All
things being equal I think the `ConnectionSupplier` is at least as readable as
the alternative you have proposed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 594169)
Time Spent: 0.5h (was: 20m)
> Potential duplicate messages with LVQ + non-destructive
> -------------------------------------------------------
>
> Key: ARTEMIS-3285
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3285
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: Justin Bertram
> Assignee: Justin Bertram
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
