[
https://issues.apache.org/jira/browse/ARTEMIS-3285?focusedWorklogId=594530&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-594530
]
ASF GitHub Bot logged work on ARTEMIS-3285:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 11/May/21 13:28
Start Date: 11/May/21 13:28
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on a change in pull request
#3569:
URL: https://github.com/apache/activemq-artemis/pull/3569#discussion_r630167338
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/Queue.java
##########
@@ -497,4 +497,8 @@ default void errorProcessing(Consumer consumer, Throwable
t, MessageReference me
default QueueConfiguration getQueueConfiguration() {
return null;
}
+
+ default boolean canBeDelivered(MessageReference ref) {
Review comment:
This is also breaking the contract on the Queue...
You have Queue::deliver already checking the message on handle(ref,
consumer);
Whatever happens here needs to be treated inside handle.
Perhaps having a specialized version of handle would be a better choice.
having this canBeDelivered happened at the proceedDeliver can create a lot
of other issues... like I'm predicting with leaving references and message on
the journal and paging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 594530)
Time Spent: 1h 50m (was: 1h 40m)
> Potential duplicate messages with LVQ + non-destructive
> -------------------------------------------------------
>
> Key: ARTEMIS-3285
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3285
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: Justin Bertram
> Assignee: Justin Bertram
> Priority: Major
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
