[
https://issues.apache.org/jira/browse/ARTEMIS-3285?focusedWorklogId=594524&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-594524
]
ASF GitHub Bot logged work on ARTEMIS-3285:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 11/May/21 13:21
Start Date: 11/May/21 13:21
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on a change in pull request
#3569:
URL: https://github.com/apache/activemq-artemis/pull/3569#discussion_r630161241
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ServerConsumerImpl.java
##########
@@ -1166,17 +1166,19 @@ private void resumeLargeMessage() {
* @param message
*/
private void deliverStandardMessage(final MessageReference ref, Message
message) throws ActiveMQException {
- applyPrefixForLegacyConsumer(message);
- int packetSize = callback.sendMessage(ref, message,
ServerConsumerImpl.this, ref.getDeliveryCount());
+ if (messageQueue.canBeDelivered(ref)) {
+ applyPrefixForLegacyConsumer(message);
+ int packetSize = callback.sendMessage(ref, message,
ServerConsumerImpl.this, ref.getDeliveryCount());
- if (availableCredits != null) {
- availableCredits.addAndGet(-packetSize);
+ if (availableCredits != null) {
+ availableCredits.addAndGet(-packetSize);
- if (logger.isTraceEnabled()) {
- logger.trace(this + "::FlowControl::delivery standard taking " +
- packetSize +
- " from credits, available now is " +
- availableCredits);
+ if (logger.isTraceEnabled()) {
+ logger.trace(this + "::FlowControl::delivery standard taking " +
+ packetSize +
+ " from credits, available now is " +
+ availableCredits);
+ }
}
Review comment:
You don't need to ack the message if not?
This will create a big leakage on the journal
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ServerConsumerImpl.java
##########
@@ -1166,17 +1166,19 @@ private void resumeLargeMessage() {
* @param message
*/
private void deliverStandardMessage(final MessageReference ref, Message
message) throws ActiveMQException {
- applyPrefixForLegacyConsumer(message);
- int packetSize = callback.sendMessage(ref, message,
ServerConsumerImpl.this, ref.getDeliveryCount());
+ if (messageQueue.canBeDelivered(ref)) {
+ applyPrefixForLegacyConsumer(message);
+ int packetSize = callback.sendMessage(ref, message,
ServerConsumerImpl.this, ref.getDeliveryCount());
- if (availableCredits != null) {
- availableCredits.addAndGet(-packetSize);
+ if (availableCredits != null) {
+ availableCredits.addAndGet(-packetSize);
- if (logger.isTraceEnabled()) {
- logger.trace(this + "::FlowControl::delivery standard taking " +
- packetSize +
- " from credits, available now is " +
- availableCredits);
+ if (logger.isTraceEnabled()) {
+ logger.trace(this + "::FlowControl::delivery standard taking " +
+ packetSize +
+ " from credits, available now is " +
+ availableCredits);
+ }
}
Review comment:
.. and paging
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 594524)
Time Spent: 1.5h (was: 1h 20m)
> Potential duplicate messages with LVQ + non-destructive
> -------------------------------------------------------
>
> Key: ARTEMIS-3285
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3285
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: Justin Bertram
> Assignee: Justin Bertram
> Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
