[ 
https://issues.apache.org/jira/browse/ARTEMIS-3367?focusedWorklogId=633344&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-633344
 ]

ASF GitHub Bot logged work on ARTEMIS-3367:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 04/Aug/21 08:11
            Start Date: 04/Aug/21 08:11
    Worklog Time Spent: 10m 
      Work Description: gemmellr commented on a change in pull request #3667:
URL: https://github.com/apache/activemq-artemis/pull/3667#discussion_r682390004



##########
File path: examples/features/standard/jmx-ssl/readme.md
##########
@@ -16,12 +16,54 @@ With these properties, ActiveMQ Artemis broker will be 
manageable remotely using
 
 The various keystore files are generated using the following commands:
 
-* `keytool -genkey -keystore server-side-keystore.jks -storepass secureexample 
-keypass secureexample -dname "CN=ActiveMQ Artemis Server, OU=Artemis, 
O=ActiveMQ, L=AMQ, S=AMQ, C=AMQ" -keyalg RSA`
-* `keytool -export -keystore server-side-keystore.jks -file 
server-side-cert.cer -storepass secureexample`
-* `keytool -import -keystore client-side-truststore.jks -file 
server-side-cert.cer -storepass secureexample -keypass secureexample -noprompt`
-* `keytool -genkey -keystore client-side-keystore.jks -storepass secureexample 
-keypass secureexample -dname "CN=ActiveMQ Artemis Client, OU=Artemis, 
O=ActiveMQ, L=AMQ, S=AMQ, C=AMQ" -keyalg RSA`
-* `keytool -export -keystore client-side-keystore.jks -file 
client-side-cert.cer -storepass secureexample`
-* `keytool -import -keystore server-side-truststore.jks -file 
client-side-cert.cer -storepass secureexample -keypass secureexample -noprompt`
+```shell
+#!/bin/bash
+set -e
+
+KEY_PASS=securepass
+STORE_PASS=securepass
+CA_VALIDITY=365000
+VALIDITY=36500

Review comment:
       I did get that, but I think the value is just unnecessarily large. So 
much so that people who dont know (and dont spot there is a 0 difference at the 
end, which I didnt initially) are likely to believe its something else.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 633344)
    Time Spent: 2h 10m  (was: 2h)

> The verifyHost parameter default value should be changed
> --------------------------------------------------------
>
>                 Key: ARTEMIS-3367
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-3367
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>          Components: Configuration
>    Affects Versions: 2.17.0
>            Reporter: Emmanuel Hugonnet
>            Assignee: Domenico Francesco Bruscino
>            Priority: Major
>          Time Spent: 2h 10m
>  Remaining Estimate: 0h
>
> Currently the acceptor/connector *verifyHost* parameter is set to 'false' per 
> default. We should provide a better out of the box experience by setting it 
> to true per default for connectors.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to