[
https://issues.apache.org/jira/browse/ARTEMIS-3367?focusedWorklogId=633356&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-633356
]
ASF GitHub Bot logged work on ARTEMIS-3367:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 04/Aug/21 08:24
Start Date: 04/Aug/21 08:24
Worklog Time Spent: 10m
Work Description: gemmellr commented on a change in pull request #3667:
URL: https://github.com/apache/activemq-artemis/pull/3667#discussion_r682399848
##########
File path:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/ssl/CoreClientOverOneWaySSLTest.java
##########
@@ -82,60 +85,18 @@ public CoreClientOverOneWaySSLTest(String storeProvider,
String storeType, boole
if (suffix.equalsIgnoreCase("PKCS12")) {
suffix = "p12";
}
- SERVER_SIDE_KEYSTORE = "server-side-keystore." + suffix;
- CLIENT_SIDE_TRUSTSTORE = "client-side-truststore." + suffix;
+ SERVER_SIDE_KEYSTORE = "server-keystore." + suffix;
+ CLIENT_SIDE_TRUSTSTORE = "server-ca-truststore." + suffix;
Review comment:
I would hope the comments showed that I actually do understand what it
is doing. I'm the one who argued that the tests should use CAs. I just think
the different naming chosen adds scope for confusion, and is likely to trip
people up who are used to the previous (and I would say more typical) naming
format where the file name pointed to where it is used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 633356)
Time Spent: 2.5h (was: 2h 20m)
> The verifyHost parameter default value should be changed
> --------------------------------------------------------
>
> Key: ARTEMIS-3367
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3367
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Configuration
> Affects Versions: 2.17.0
> Reporter: Emmanuel Hugonnet
> Assignee: Domenico Francesco Bruscino
> Priority: Major
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> Currently the acceptor/connector *verifyHost* parameter is set to 'false' per
> default. We should provide a better out of the box experience by setting it
> to true per default for connectors.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
