[
https://issues.apache.org/jira/browse/ARTEMIS-3367?focusedWorklogId=633353&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-633353
]
ASF GitHub Bot logged work on ARTEMIS-3367:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 04/Aug/21 08:18
Start Date: 04/Aug/21 08:18
Worklog Time Spent: 10m
Work Description: gemmellr commented on a change in pull request #3667:
URL: https://github.com/apache/activemq-artemis/pull/3667#discussion_r682395429
##########
File path:
tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/remoting/impl/netty/NettyConnectorTest.java
##########
@@ -56,10 +59,10 @@ public void setUp() throws Exception {
Map<String, Object> params = new HashMap<>();
params.put(TransportConstants.SSL_ENABLED_PROP_NAME, true);
params.put(TransportConstants.SSL_PROVIDER,
TransportConstants.OPENSSL_PROVIDER);
- params.put(TransportConstants.KEYSTORE_PATH_PROP_NAME,
"openssl-server-side-keystore.jks");
- params.put(TransportConstants.KEYSTORE_PASSWORD_PROP_NAME,
"secureexample");
- params.put(TransportConstants.TRUSTSTORE_PATH_PROP_NAME,
"openssl-server-side-truststore.jks");
- params.put(TransportConstants.TRUSTSTORE_PASSWORD_PROP_NAME,
"secureexample");
+ params.put(TransportConstants.KEYSTORE_PATH_PROP_NAME,
"server-keystore.jks");
+ params.put(TransportConstants.KEYSTORE_PASSWORD_PROP_NAME, "securepass");
+ params.put(TransportConstants.TRUSTSTORE_PATH_PROP_NAME,
"client-ca-truststore.jks");
+ params.put(TransportConstants.TRUSTSTORE_PASSWORD_PROP_NAME,
"securepass");
Review comment:
The problem is one of them still reads like it mainly conveys the
purpose rather than the content, which makes the other one seem like it does
too, leading to the combination being confusing, more so when historically the
name was historically where it was being used.
I didnt particularly see need for the '-side' expansion in the old names,
but together the old names were far clearer to me than the replacements. I
fully expect people not copying an existing test to mess up using these, I know
I likely will.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 633353)
Time Spent: 2h 20m (was: 2h 10m)
> The verifyHost parameter default value should be changed
> --------------------------------------------------------
>
> Key: ARTEMIS-3367
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3367
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Configuration
> Affects Versions: 2.17.0
> Reporter: Emmanuel Hugonnet
> Assignee: Domenico Francesco Bruscino
> Priority: Major
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> Currently the acceptor/connector *verifyHost* parameter is set to 'false' per
> default. We should provide a better out of the box experience by setting it
> to true per default for connectors.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
