[
https://issues.apache.org/jira/browse/ARTEMIS-3692?focusedWorklogId=777059&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-777059
]
ASF GitHub Bot logged work on ARTEMIS-3692:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 01/Jun/22 17:52
Start Date: 01/Jun/22 17:52
Worklog Time Spent: 10m
Work Description: jbertram commented on code in PR #4099:
URL: https://github.com/apache/activemq-artemis/pull/4099#discussion_r887143693
##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/proton/ProtonServerReceiverContext.java:
##########
@@ -127,7 +136,7 @@ public void initialize() throws Exception {
}
try {
- sessionSPI.check(address, CheckType.SEND,
connection.getSecurityAuth());
+ sessionSPI.check(address, CheckType.SEND,
connection.getSecurityAuth(),
Arrays.stream(target.getCapabilities()).anyMatch(c ->
c.equals(TEMP_QUEUE_CAPABILITY) || c.equals(TEMP_TOPIC_CAPABILITY)));
Review Comment:
Looking at this more closely in context this will never be for a temporary
address so the check is actually completely unnecessary. Will revert.
Issue Time Tracking
-------------------
Worklog Id: (was: 777059)
Time Spent: 1.5h (was: 1h 20m)
> Extend Functionality of Temporary Queue Namespace to Security Settings
> ----------------------------------------------------------------------
>
> Key: ARTEMIS-3692
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3692
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Kevin O'Neal
> Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Currently the temporary-queue-namespace is only relevant for
> address-settings, not security-settings. Therefore, the only way to enforce
> security settings on temporary queues is to use the match "#".
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
