[jira] [Work logged] (ARTEMIS-3692) Extend Functionality of Temporary Queue Namespace to Security Settings

[ASF GitHub Bot (Jira)]

     [ 
https://issues.apache.org/jira/browse/ARTEMIS-3692?focusedWorklogId=777077&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-777077
 ]

ASF GitHub Bot logged work on ARTEMIS-3692:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 01/Jun/22 18:12
            Start Date: 01/Jun/22 18:12
    Worklog Time Spent: 10m 
      Work Description: jbertram commented on code in PR #4099:
URL: https://github.com/apache/activemq-artemis/pull/4099#discussion_r887161193


##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/proton/ProtonServerReceiverContext.java:
##########
@@ -271,7 +280,13 @@ public void close(boolean remoteLinkClose) throws 
ActiveMQAMQPException {
       org.apache.qpid.proton.amqp.messaging.Target target = 
(org.apache.qpid.proton.amqp.messaging.Target) receiver.getRemoteTarget();
       if (target != null && target.getDynamic() && (target.getExpiryPolicy() 
== TerminusExpiryPolicy.LINK_DETACH || target.getExpiryPolicy() == 
TerminusExpiryPolicy.SESSION_END)) {
          try {
-            
sessionSPI.removeTemporaryQueue(SimpleString.toSimpleString(target.getAddress()));
+            if (Arrays.stream(target.getCapabilities()).anyMatch(c -> 
c.equals(TEMP_QUEUE_CAPABILITY))) {
+               
sessionSPI.removeTemporaryQueue(SimpleString.toSimpleString(target.getAddress()));
+            } else {
+               
sessionSPI.removeTemporaryAddress(SimpleString.toSimpleString(target.getAddress()));
+            }

Review Comment:
   Good point. I'll check the actual queue (or lack thereof) on the broker.





Issue Time Tracking
-------------------

    Worklog Id:     (was: 777077)
    Time Spent: 1h 40m  (was: 1.5h)

> Extend Functionality of Temporary Queue Namespace to Security Settings
> ----------------------------------------------------------------------
>
>                 Key: ARTEMIS-3692
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-3692
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>            Reporter: Kevin O'Neal
>            Priority: Major
>          Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> Currently the temporary-queue-namespace is only relevant for 
> address-settings, not security-settings. Therefore, the only way to enforce 
> security settings on temporary queues is to use the match "#".



--
This message was sent by Atlassian Jira
(v8.20.7#820007)