[ 
https://issues.apache.org/jira/browse/ARTEMIS-3692?focusedWorklogId=777083&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-777083
 ]

ASF GitHub Bot logged work on ARTEMIS-3692:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 01/Jun/22 18:20
            Start Date: 01/Jun/22 18:20
    Worklog Time Spent: 10m 
      Work Description: jbertram commented on code in PR #4099:
URL: https://github.com/apache/activemq-artemis/pull/4099#discussion_r887168259


##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/proton/ProtonServerReceiverContext.java:
##########
@@ -95,7 +100,11 @@ public void initialize() throws Exception {
             defRoutingType = getRoutingType(target.getCapabilities(), address);
 
             try {
-               sessionSPI.createTemporaryQueue(address, defRoutingType);
+               if (defRoutingType == RoutingType.ANYCAST) {
+                  sessionSPI.createTemporaryQueue(address, defRoutingType);

Review Comment:
   The current implementation doesn't change the name of the resource; it just 
changes the way the resource is looked up in the relevant 
`HierarchicalRepository`. The same was done for the address-settings. However, 
it _might_ be simpler to change the actual name of the resource rather than the 
look-up, but the devil is in the details. I'm not sure I could say conclusively 
it would actually be simpler until I implemented it.





Issue Time Tracking
-------------------

    Worklog Id:     (was: 777083)
    Time Spent: 1h 50m  (was: 1h 40m)

> Extend Functionality of Temporary Queue Namespace to Security Settings
> ----------------------------------------------------------------------
>
>                 Key: ARTEMIS-3692
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-3692
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>            Reporter: Kevin O'Neal
>            Priority: Major
>          Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> Currently the temporary-queue-namespace is only relevant for 
> address-settings, not security-settings. Therefore, the only way to enforce 
> security settings on temporary queues is to use the match "#".



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to