[
https://issues.apache.org/jira/browse/ARTEMIS-3850?focusedWorklogId=779086&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-779086
]
ASF GitHub Bot logged work on ARTEMIS-3850:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 07/Jun/22 13:18
Start Date: 07/Jun/22 13:18
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #4101:
URL: https://github.com/apache/activemq-artemis/pull/4101#discussion_r891214441
##########
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/SizeAwareMetric.java:
##########
@@ -59,6 +59,13 @@ public interface AddCallback {
private Runnable underCallback;
+ /** To be used in a case where we just measure elements */
+ public SizeAwareMetric() {
+ this.sizeEnabled = false;
+ this.elementsEnabled = false;
+ }
Review Comment:
I would need to use two AtomicInteger on QueueImpl, one for the size in
bytes, not for the size in messages.
I use this to determine when to stop reading from paging.
Besides I could eventually start using some of the callback methods.
Issue Time Tracking
-------------------
Worklog Id: (was: 779086)
Time Spent: 1h 10m (was: 1h)
> Add Option to read messages into paging based on sizing and eliminate caching
> -----------------------------------------------------------------------------
>
> Key: ARTEMIS-3850
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3850
> Project: ActiveMQ Artemis
> Issue Type: New Feature
> Affects Versions: 2.22.0
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Fix For: 2.23.0
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
