[
https://issues.apache.org/jira/browse/ARTEMIS-3850?focusedWorklogId=779252&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-779252
]
ASF GitHub Bot logged work on ARTEMIS-3850:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 07/Jun/22 20:32
Start Date: 07/Jun/22 20:32
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #4101:
URL: https://github.com/apache/activemq-artemis/pull/4101#discussion_r891684103
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java:
##########
@@ -207,8 +208,8 @@ private void checkIDSupplier(NodeStore<MessageReference>
nodeStore) {
// The quantity of pagedReferences on messageReferences priority list
private final AtomicInteger pagedReferences = new AtomicInteger(0);
- // The estimate of memory being consumed by this queue. Used to calculate
instances of messages to depage
- final AtomicInteger queueMemorySize = new AtomicInteger(0);
+
+ final SizeAwareMetric queueMemorySize = new SizeAwareMetric();
Review Comment:
@gemmellr I preferred to use the SizeAwareMetric here instead of introducing
a new counter.
Issue Time Tracking
-------------------
Worklog Id: (was: 779252)
Time Spent: 2h 40m (was: 2.5h)
> Add Option to read messages into paging based on sizing and eliminate caching
> -----------------------------------------------------------------------------
>
> Key: ARTEMIS-3850
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3850
> Project: ActiveMQ Artemis
> Issue Type: New Feature
> Affects Versions: 2.22.0
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Fix For: 2.24.0
>
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
