[
https://issues.apache.org/jira/browse/ARTEMIS-3850?focusedWorklogId=779268&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-779268
]
ASF GitHub Bot logged work on ARTEMIS-3850:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 07/Jun/22 22:18
Start Date: 07/Jun/22 22:18
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #4101:
URL: https://github.com/apache/activemq-artemis/pull/4101#discussion_r891754596
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/deployers/impl/FileConfigurationParser.java:
##########
@@ -1261,6 +1265,14 @@ protected Pair<String, AddressSettings>
parseAddressSettings(final Node node) {
long pageSizeLong =
ByteUtil.convertTextBytes(getTrimmedTextContent(child));
Validators.POSITIVE_INT.validate(PAGE_SIZE_BYTES_NODE_NAME,
pageSizeLong);
addressSettings.setPageSizeBytes((int) pageSizeLong);
+ } else if (MAX_READ_PAGE_MESSAGES_NODE_NAME.equalsIgnoreCase(name)) {
+ long maxReadPageMessages =
Long.parseLong(getTrimmedTextContent(child));
+ Validators.POSITIVE_INT.validate(PAGE_SIZE_BYTES_NODE_NAME,
maxReadPageMessages);
+ addressSettings.setMaxReadPageMessages((int)maxReadPageMessages);
+ } else if (MAX_READ_PAGE_BYTES_NODE_NAME.equalsIgnoreCase(name)) {
+ long maxReadPageBytes =
ByteUtil.convertTextBytes(getTrimmedTextContent(child));
+ Validators.POSITIVE_INT.validate(PAGE_SIZE_BYTES_NODE_NAME,
maxReadPageBytes);
Review Comment:
wow... you're good man! thanks!
Issue Time Tracking
-------------------
Worklog Id: (was: 779268)
Time Spent: 3h 20m (was: 3h 10m)
> Add Option to read messages into paging based on sizing and eliminate caching
> -----------------------------------------------------------------------------
>
> Key: ARTEMIS-3850
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3850
> Project: ActiveMQ Artemis
> Issue Type: New Feature
> Affects Versions: 2.22.0
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Fix For: 2.24.0
>
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
