[
https://issues.apache.org/jira/browse/ARTEMIS-4106?focusedWorklogId=830974&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-830974
]
ASF GitHub Bot logged work on ARTEMIS-4106:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 05/Dec/22 09:45
Start Date: 05/Dec/22 09:45
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #4302:
URL: https://github.com/apache/activemq-artemis/pull/4302#discussion_r1039364600
##########
artemis-protocols/artemis-openwire-protocol/src/test/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireMessageConverterTest.java:
##########
@@ -248,6 +248,7 @@ public void testBadPropertyConversion() throws Exception {
coreMessage.putStringProperty(hdrBrokerInTime, "5678");
coreMessage.putStringProperty(hdrCommandId, "foo");
coreMessage.putStringProperty(hdrDroppable, "true");
+ coreMessage.putStringProperty("", "");
Review Comment:
I'd agree either the test or the impl should be doing something else than it
currently is.
The test doesnt look to do anything to check what happens to this empty
prop, so it seems like it would just behave the same if the impl behaviour went
back to what it was, i.e it doesnt really test the fixed issue/behaviour.
Perhaps the test could do something like verify the count of expected props
to ensure no unexpected props are there beyond those its checking values for.
Or as Dom suggests the prop setter impl could also throw (the test could still
check there isnt anything unexpected after conversion). Though that will
obviously break whatever situation allowed the position there was to be an
empty prop key in the Core message to begin with.
Issue Time Tracking
-------------------
Worklog Id: (was: 830974)
Time Spent: 20m (was: 10m)
> Do not set property with empty key name when converting to OpenWire
> -------------------------------------------------------------------
>
> Key: ARTEMIS-4106
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4106
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: Justin Bertram
> Assignee: Justin Bertram
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
