[
https://issues.apache.org/jira/browse/ARTEMIS-4106?focusedWorklogId=831085&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-831085
]
ASF GitHub Bot logged work on ARTEMIS-4106:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 05/Dec/22 16:11
Start Date: 05/Dec/22 16:11
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #4302:
URL: https://github.com/apache/activemq-artemis/pull/4302#discussion_r1039795852
##########
artemis-protocols/artemis-openwire-protocol/src/test/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireMessageConverterTest.java:
##########
@@ -248,6 +248,7 @@ public void testBadPropertyConversion() throws Exception {
coreMessage.putStringProperty(hdrBrokerInTime, "5678");
coreMessage.putStringProperty(hdrCommandId, "foo");
coreMessage.putStringProperty(hdrDroppable, "true");
+ coreMessage.putStringProperty("", "");
Review Comment:
Ah ok. I'd probably still add additional verification as without looking at
the git history and perhaps finding this discussion I'd still have no real idea
why that line was there in the test or what exactly to expect from it, given it
doesnt say or do any obvious related verification.
On the other bit, you could add verification on the setter and also a [URI]
option to disable it should someone truly need it. As the JIRA has no detail
its not clear how this is actually coming up currently.
Issue Time Tracking
-------------------
Worklog Id: (was: 831085)
Time Spent: 40m (was: 0.5h)
> Do not set property with empty key name when converting to OpenWire
> -------------------------------------------------------------------
>
> Key: ARTEMIS-4106
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4106
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: Justin Bertram
> Assignee: Justin Bertram
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
