[
https://issues.apache.org/jira/browse/ARTEMIS-4106?focusedWorklogId=831084&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-831084
]
ASF GitHub Bot logged work on ARTEMIS-4106:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 05/Dec/22 16:01
Start Date: 05/Dec/22 16:01
Worklog Time Spent: 10m
Work Description: jbertram commented on code in PR #4302:
URL: https://github.com/apache/activemq-artemis/pull/4302#discussion_r1039784079
##########
artemis-protocols/artemis-openwire-protocol/src/test/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireMessageConverterTest.java:
##########
@@ -248,6 +248,7 @@ public void testBadPropertyConversion() throws Exception {
coreMessage.putStringProperty(hdrBrokerInTime, "5678");
coreMessage.putStringProperty(hdrCommandId, "foo");
coreMessage.putStringProperty(hdrDroppable, "true");
+ coreMessage.putStringProperty("", "");
Review Comment:
@brusdev, my concern is breaking anybody who is actually using this
"functionality."
@gemmellr, it's not obvious from the test, but if there's a property with an
empty name it will trigger a `java.lang.IllegalArgumentException` in accordance
with the [JMS
spec](https://docs.oracle.com/javaee/7/api/javax/jms/Message.html#setObjectProperty-java.lang.String-java.lang.Object-).
Therefore, if the test completes then by definition no exception was thrown
during conversion.
Issue Time Tracking
-------------------
Worklog Id: (was: 831084)
Time Spent: 0.5h (was: 20m)
> Do not set property with empty key name when converting to OpenWire
> -------------------------------------------------------------------
>
> Key: ARTEMIS-4106
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4106
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: Justin Bertram
> Assignee: Justin Bertram
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
