[
https://issues.apache.org/jira/browse/ARTEMIS-4245?focusedWorklogId=859464&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-859464
]
ASF GitHub Bot logged work on ARTEMIS-4245:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 27/Apr/23 18:24
Start Date: 27/Apr/23 18:24
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #4441:
URL: https://github.com/apache/activemq-artemis/pull/4441#discussion_r1179539330
##########
artemis-web/src/test/java/org/apache/activemq/cli/test/WebServerComponentTest.java:
##########
@@ -215,11 +221,11 @@ public void testComponentStopStartBehavior() throws
Exception {
Assert.assertFalse(webServerComponent.isStarted());
}
- @Test
- public void simpleSecureServer() throws Exception {
+ private WebServerComponent startSimpleSecureServer(String keyStorePath,
String keyStorePassword, Boolean sniHostCheck) throws Exception {
BindingDTO bindingDTO = new BindingDTO();
bindingDTO.uri = "https://localhost:0";;
bindingDTO.keyStorePath = "./src/test/resources/server.keystore";
+ bindingDTO.setSniHostCheck(sniHostCheck);
Review Comment:
Sure, but the comment was just about 'getting the default behaviour' rather
than explicitly setting the null (whichone testdoes), and instead relying on
the bonafiide default behaviour so it could be verified to match what we expect.
Issue Time Tracking
-------------------
Worklog Id: (was: 859464)
Time Spent: 40m (was: 0.5h)
> Expose web SNI settings
> -----------------------
>
> Key: ARTEMIS-4245
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4245
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Domenico Francesco Bruscino
> Assignee: Domenico Francesco Bruscino
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Expose sniHostCheck and sniRequired settings in the web config.
> {code:xml}
> <web path="web" rootRedirectLocation="console">
> <binding uri="http://localhost:8161"; sniHostCheck="false"
> sniRequired="false">
> ...
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
