[
https://issues.apache.org/jira/browse/ARTEMIS-4245?focusedWorklogId=860051&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-860051
]
ASF GitHub Bot logged work on ARTEMIS-4245:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 02/May/23 11:49
Start Date: 02/May/23 11:49
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #4441:
URL: https://github.com/apache/activemq-artemis/pull/4441#discussion_r1182438994
##########
artemis-web/src/main/java/org/apache/activemq/artemis/component/WebServerComponent.java:
##########
@@ -245,7 +245,10 @@ private ServerConnector
createServerConnector(HttpConfiguration httpConfiguratio
SslConnectionFactory sslConnectionFactory = new
SslConnectionFactory(sslFactory, "HTTP/1.1");
- httpConfiguration.addCustomizer(new SecureRequestCustomizer());
+ SecureRequestCustomizer secureRequestCustomizer = new
SecureRequestCustomizer();
+ secureRequestCustomizer.setSniHostCheck(binding.getSniHostCheck() !=
null ? binding.getSniHostCheck() : true);
+ secureRequestCustomizer.setSniRequired(binding.getSniRequired() !=
null ? binding.getSniRequired() : false);
Review Comment:
Perhaps constants for the defaults?
##########
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/web/WebServerDTOConfigTest.java:
##########
@@ -97,6 +97,8 @@ private void testSetWebBindingProperties(WebServerDTO
webServer, String bindingN
properties.put(ActiveMQDefaultConfiguration.getDefaultSystemWebPropertyPrefix()
+ "bindings." + bindingName + ".excludedCipherSuites",
"test-excludedCipherSuites,3");
properties.put(ActiveMQDefaultConfiguration.getDefaultSystemWebPropertyPrefix()
+ "bindings." + bindingName + ".keyStorePassword", "test-keyStorePassword");
properties.put(ActiveMQDefaultConfiguration.getDefaultSystemWebPropertyPrefix()
+ "bindings." + bindingName + ".trustStorePassword", "test-trustStorePassword");
+
properties.put(ActiveMQDefaultConfiguration.getDefaultSystemWebPropertyPrefix()
+ "bindings." + bindingName + ".sniHostCheck", "true");
+
properties.put(ActiveMQDefaultConfiguration.getDefaultSystemWebPropertyPrefix()
+ "bindings." + bindingName + ".sniRequired", "true");
Review Comment:
These are both being set true...meaning one is being set to its
already-expected default and the other isnt. Perhaps have both set the
non-default value?
Issue Time Tracking
-------------------
Worklog Id: (was: 860051)
Time Spent: 1h (was: 50m)
> Expose web SNI settings
> -----------------------
>
> Key: ARTEMIS-4245
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4245
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Domenico Francesco Bruscino
> Assignee: Domenico Francesco Bruscino
> Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Expose sniHostCheck and sniRequired settings in the web config.
> {code:xml}
> <web path="web" rootRedirectLocation="console">
> <binding uri="http://localhost:8161"; sniHostCheck="false"
> sniRequired="false">
> ...
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
