[
https://issues.apache.org/jira/browse/ARTEMIS-4245?focusedWorklogId=860103&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-860103
]
ASF GitHub Bot logged work on ARTEMIS-4245:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 02/May/23 13:46
Start Date: 02/May/23 13:46
Worklog Time Spent: 10m
Work Description: brusdev commented on code in PR #4441:
URL: https://github.com/apache/activemq-artemis/pull/4441#discussion_r1182573038
##########
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/web/WebServerDTOConfigTest.java:
##########
@@ -97,6 +97,8 @@ private void testSetWebBindingProperties(WebServerDTO
webServer, String bindingN
properties.put(ActiveMQDefaultConfiguration.getDefaultSystemWebPropertyPrefix()
+ "bindings." + bindingName + ".excludedCipherSuites",
"test-excludedCipherSuites,3");
properties.put(ActiveMQDefaultConfiguration.getDefaultSystemWebPropertyPrefix()
+ "bindings." + bindingName + ".keyStorePassword", "test-keyStorePassword");
properties.put(ActiveMQDefaultConfiguration.getDefaultSystemWebPropertyPrefix()
+ "bindings." + bindingName + ".trustStorePassword", "test-trustStorePassword");
+
properties.put(ActiveMQDefaultConfiguration.getDefaultSystemWebPropertyPrefix()
+ "bindings." + bindingName + ".sniHostCheck", "true");
+
properties.put(ActiveMQDefaultConfiguration.getDefaultSystemWebPropertyPrefix()
+ "bindings." + bindingName + ".sniRequired", "true");
Review Comment:
BindingDTO default values for `sniHostCheck` and `sniRequired` are `null`
but using WebServerComponent non-default value should to avoid confusion.
Issue Time Tracking
-------------------
Worklog Id: (was: 860103)
Time Spent: 1h 10m (was: 1h)
> Expose web SNI settings
> -----------------------
>
> Key: ARTEMIS-4245
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4245
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Domenico Francesco Bruscino
> Assignee: Domenico Francesco Bruscino
> Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Expose sniHostCheck and sniRequired settings in the web config.
> {code:xml}
> <web path="web" rootRedirectLocation="console">
> <binding uri="http://localhost:8161"; sniHostCheck="false"
> sniRequired="false">
> ...
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
