[
https://issues.apache.org/jira/browse/ARTEMIS-4332?focusedWorklogId=868083&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-868083
]
ASF GitHub Bot logged work on ARTEMIS-4332:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 28/Jun/23 11:15
Start Date: 28/Jun/23 11:15
Worklog Time Spent: 10m
Work Description: brusdev commented on code in PR #4526:
URL: https://github.com/apache/activemq-artemis/pull/4526#discussion_r1245062445
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/OperationContextImpl.java:
##########
@@ -415,4 +449,27 @@ public String toString() {
executorsPendingField +
"]";
}
+
+ @Override
+ public void clear() {
+ stored = 0;
+ storeLineUpField = 0;
+ minimalReplicated = 0;
+ replicated = 0;
+ replicationLineUpField = 0;
+ paged = 0;
+ minimalPage = 0;
+ pageLineUpField = 0;
+ errorCode = -1;
+ errorMessage = null;
+ executorsPendingField = 0;
+
+ if (tasks != null) {
+ tasks.clear();
+ }
+
+ if (storeOnlyTasks != null) {
+ storeOnlyTasks.clear();
+ }
Review Comment:
@gemmellr yes this could potentially be a concurrent operation and it could
cause inconsistent state. I could change it to be thread-safe but I'm not sure
this is necessary. I mean this method should be the last chance to close a
stuck session and it is supposed to be manually called by a user. If the call
is successful the context/session will be closed otherwise users could retry.
Issue Time Tracking
-------------------
Worklog Id: (was: 868083)
Remaining Estimate: 0h
Time Spent: 10m
> Add management method to close stuck server sessions
> ----------------------------------------------------
>
> Key: ARTEMIS-4332
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4332
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Domenico Francesco Bruscino
> Assignee: Domenico Francesco Bruscino
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In rare cases a store operation could silently fails or starves, blocking the
> related server session and all delivering messages. Those server sessions can
> be closed adding a management method that cleans their operation context
> before closing them.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
