[
https://issues.apache.org/jira/browse/ARTEMIS-4332?focusedWorklogId=869576&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-869576
]
ASF GitHub Bot logged work on ARTEMIS-4332:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 06/Jul/23 14:34
Start Date: 06/Jul/23 14:34
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #4526:
URL: https://github.com/apache/activemq-artemis/pull/4526#discussion_r1254532745
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/OperationContextImpl.java:
##########
@@ -104,6 +107,29 @@ public static void setContext(final OperationContext
context) {
private final Executor executor;
+ public static final String MAX_STORE_OPERATION_TRACKERS_PROP =
"artemis.maxStoreOperationTrackers";
+
+ private static int maxStoreOperationTrackers = -1;
Review Comment:
- I think this should be final
and it should be initialized with a static initializer, or simply use the
System.getProperty straight away.
{
}
- Also the property name. and the pattern used here.
RefCountMessage used a different pattern. I think we should stick to the
same pattern used in there.
ARTEMIS_
and maxStoreOperationsTrackers.. it doesn't not really translate to anything
unless I read the code and understand what is doing.
I'm not sure what better name we could use (I'm terrible with names). but
what about:
ARTEMIS_OPCONTEXT_TRACKER_NUMBER?
And some javadoc of what it does?
Issue Time Tracking
-------------------
Worklog Id: (was: 869576)
Time Spent: 1h (was: 50m)
> Add management method to close stuck server sessions
> ----------------------------------------------------
>
> Key: ARTEMIS-4332
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4332
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Domenico Francesco Bruscino
> Assignee: Domenico Francesco Bruscino
> Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
> In rare cases a store operation could silently fails or starves, blocking the
> related server session and all delivering messages. Those server sessions can
> be closed adding a management method that cleans their operation context
> before closing them.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
