[
https://issues.apache.org/jira/browse/ARTEMIS-4332?focusedWorklogId=868181&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-868181
]
ASF GitHub Bot logged work on ARTEMIS-4332:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 28/Jun/23 14:43
Start Date: 28/Jun/23 14:43
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #4526:
URL: https://github.com/apache/activemq-artemis/pull/4526#discussion_r1245342785
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/OperationContextImpl.java:
##########
@@ -415,4 +449,27 @@ public String toString() {
executorsPendingField +
"]";
}
+
+ @Override
+ public void clear() {
+ stored = 0;
+ storeLineUpField = 0;
+ minimalReplicated = 0;
+ replicated = 0;
+ replicationLineUpField = 0;
+ paged = 0;
+ minimalPage = 0;
+ pageLineUpField = 0;
+ errorCode = -1;
+ errorMessage = null;
+ executorsPendingField = 0;
+
+ if (tasks != null) {
+ tasks.clear();
+ }
+
+ if (storeOnlyTasks != null) {
+ storeOnlyTasks.clear();
+ }
Review Comment:
So I guess the question is really just, what are the potential consequences
of corrupting the list and is it important?
Closing 'stuck' sessions is what the method is being added for, but its not
necessarily when it will actually be called. I expect some folks will use the
'force' just because it exists at all, to avoid having to think whether they
actually need it or not. E.g the same way folks use rm -rf a lot of the time.
Issue Time Tracking
-------------------
Worklog Id: (was: 868181)
Time Spent: 20m (was: 10m)
> Add management method to close stuck server sessions
> ----------------------------------------------------
>
> Key: ARTEMIS-4332
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4332
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Domenico Francesco Bruscino
> Assignee: Domenico Francesco Bruscino
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> In rare cases a store operation could silently fails or starves, blocking the
> related server session and all delivering messages. Those server sessions can
> be closed adding a management method that cleans their operation context
> before closing them.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
