[ 
https://issues.apache.org/jira/browse/ARTEMIS-4349?focusedWorklogId=878199&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-878199
 ]

ASF GitHub Bot logged work on ARTEMIS-4349:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 24/Aug/23 15:03
            Start Date: 24/Aug/23 15:03
    Worklog Time Spent: 10m 
      Work Description: gemmellr commented on PR #4584:
URL: 
https://github.com/apache/activemq-artemis/pull/4584#issuecomment-1691855301

   > See #4589.
   
   With this PR rebased after those changes went in, I retested these changes 
with and without the final commit making the eviction processing behave more 
like Guava's. As expected, both ways now pass the previously-failing test, now 
that the likely underlying issue of 'temporarily caching when max size is 0' 
issue was resolved by the other PR omitting the cache in that situation.
   
   So I guess its just a case of deciding whether we want to retain the 
guava-style inline execution behaviour, or change to the Caffeine async 
execution default.




Issue Time Tracking
-------------------

    Worklog Id:     (was: 878199)
    Time Spent: 9h 10m  (was: 9h)

> Replace Guava cache with Caffeine
> ---------------------------------
>
>                 Key: ARTEMIS-4349
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-4349
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>    Affects Versions: 2.29.0
>            Reporter: Alexey Markevich
>            Priority: Major
>          Time Spent: 9h 10m
>  Remaining Estimate: 0h
>
> based on benchmark https://github.com/ben-manes/caffeine/wiki/Benchmarks



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to