[ 
https://issues.apache.org/jira/browse/ARTEMIS-4349?focusedWorklogId=878238&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-878238
 ]

ASF GitHub Bot logged work on ARTEMIS-4349:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 24/Aug/23 18:17
            Start Date: 24/Aug/23 18:17
    Worklog Time Spent: 10m 
      Work Description: jbertram commented on code in PR #4584:
URL: https://github.com/apache/activemq-artemis/pull/4584#discussion_r1304702894


##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/security/impl/SecurityStoreImpl.java:
##########
@@ -101,15 +103,15 @@ public SecurityStoreImpl(final 
HierarchicalRepository<Set<Role>> securityReposit
       if (authenticationCacheSize == 0) {
          authenticationCache = null;
       } else {
-         authenticationCache = CacheBuilder.newBuilder()
+         authenticationCache = Caffeine.newBuilder()
                                            
.maximumSize(authenticationCacheSize)
                                            
.expireAfterWrite(invalidationInterval, TimeUnit.MILLISECONDS)
                                            .build();
       }
       if (authorizationCacheSize == 0) {
          authorizationCache = null;
       } else {
-         authorizationCache = CacheBuilder.newBuilder()
+         authorizationCache = Caffeine.newBuilder()
                                           .maximumSize(authorizationCacheSize)
                                           
.expireAfterWrite(invalidationInterval, TimeUnit.MILLISECONDS)
                                           .build();

Review Comment:
   Same as above.





Issue Time Tracking
-------------------

    Worklog Id:     (was: 878238)
    Time Spent: 9.5h  (was: 9h 20m)

> Replace Guava cache with Caffeine
> ---------------------------------
>
>                 Key: ARTEMIS-4349
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-4349
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>    Affects Versions: 2.29.0
>            Reporter: Alexey Markevich
>            Priority: Major
>          Time Spent: 9.5h
>  Remaining Estimate: 0h
>
> based on benchmark https://github.com/ben-manes/caffeine/wiki/Benchmarks



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to