[ https://issues.apache.org/jira/browse/ARTEMIS-4349?focusedWorklogId=878241&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-878241 ]
ASF GitHub Bot logged work on ARTEMIS-4349: ------------------------------------------- Author: ASF GitHub Bot Created on: 24/Aug/23 18:43 Start Date: 24/Aug/23 18:43 Worklog Time Spent: 10m Work Description: jbertram commented on PR #4584: URL: https://github.com/apache/activemq-artemis/pull/4584#issuecomment-1692229955 > So I guess its just a case of deciding whether we want to retain the guava-style inline execution behaviour, or change to the Caffeine async execution default. Regarding the cache usage in `org.apache.activemq.artemis.core.security.impl.SecurityStoreImpl` my thoughts are: 1. The only use-case where it really matters is with size = 0 and that's been fixed that already via #4589. 2. It makes sense to optimize security since it is used basically every time a client connects. Therefore, I'm in favor of using the default from Caffeine. Issue Time Tracking ------------------- Worklog Id: (was: 878241) Time Spent: 9h 40m (was: 9.5h) > Replace Guava cache with Caffeine > --------------------------------- > > Key: ARTEMIS-4349 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4349 > Project: ActiveMQ Artemis > Issue Type: Improvement > Affects Versions: 2.29.0 > Reporter: Alexey Markevich > Priority: Major > Time Spent: 9h 40m > Remaining Estimate: 0h > > based on benchmark https://github.com/ben-manes/caffeine/wiki/Benchmarks -- This message was sent by Atlassian Jira (v8.20.10#820010)