[
https://issues.apache.org/jira/browse/ARTEMIS-4510?focusedWorklogId=901141&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-901141
]
ASF GitHub Bot logged work on ARTEMIS-4510:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 23/Jan/24 08:52
Start Date: 23/Jan/24 08:52
Worklog Time Spent: 10m
Work Description: AntonRoskvist commented on PR #4681:
URL:
https://github.com/apache/activemq-artemis/pull/4681#issuecomment-1905583151
Thanks for your feedback @jbertram
I'd argue that the behavior already is configurable though, through the
"auto-create"-configs in the address-settings...
As for the performance implication, I agree that this could have some
additional cost associated with it... however the same operation is carried out
during normal routing within the postOffice, twice... at
`PostOfficeImpl#checkAddress()` and `PostOfficeImpl#simpleRoute()`.
The reason they are not applied for the diverted messages is because the
message copies does not have a reference back to their original
`ServerSession`... don't know if this is safe, but perhaps the Divert could do
this instead:
`postOffice.route(copy, new
RoutingContextImpl(context.getTransaction()).setReusable(false).setRoutingType(copy.getRoutingType()),
false);`
--->
`postOffice.route(copy, new
RoutingContextImpl(context.getTransaction()).setReusable(false).setRoutingType(copy.getRoutingType()).setServerSession(context.getServerSession()),
false);`
That way the currently implemented auto-create-logic within PostOffice would
apply instead. Thoughts on this?
And just to be clear, I'd be open to re-implement all together according to
your suggestion if you think that makes more sense, just let me know.
Issue Time Tracking
-------------------
Worklog Id: (was: 901141)
Time Spent: 0.5h (was: 20m)
> Add auto-create-destination logic to diverts
> --------------------------------------------
>
> Key: ARTEMIS-4510
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4510
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Anton Roskvist
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> This enables the use of dynamic routing decisions within the transformer by
> setting the message address. It also covers for a rare problem where if any
> of the forwarding addresses are removed during runtime, such as from
> auto-delete, the message would get silently dropped.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
