[
https://issues.apache.org/jira/browse/ARTEMIS-4510?focusedWorklogId=909785&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-909785
]
ASF GitHub Bot logged work on ARTEMIS-4510:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 14/Mar/24 03:25
Start Date: 14/Mar/24 03:25
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #4681:
URL: https://github.com/apache/activemq-artemis/pull/4681#discussion_r1524154424
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/settings/impl/AddressSettings.java:
##########
@@ -1679,7 +1699,8 @@ public int getEncodeSize() {
BufferHelper.sizeOfNullableInteger(idCacheSize) +
BufferHelper.sizeOfNullableSimpleString(pageFullMessagePolicy != null
? pageFullMessagePolicy.toString() : null) +
BufferHelper.sizeOfNullableInteger(prefetchPageBytes) +
- BufferHelper.sizeOfNullableInteger(prefetchPageMessages);
+ BufferHelper.sizeOfNullableInteger(prefetchPageMessages) +
+ BufferHelper.sizeOfNullableBoolean(autoCreateDivertDestination);
Review Comment:
I'm not sure this is needed any longer... we are not changing the wires for
the old methods.
Preetty much just use JSON for anything new now.. older stuff should stay as
is.
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/settings/impl/AddressSettings.java:
##########
@@ -1601,6 +1617,10 @@ public void decode(ActiveMQBuffer buffer, boolean
tryCompatible) {
if (buffer.readableBytes() > 0) {
prefetchPageMessages = BufferHelper.readNullableInteger(buffer);
}
+
+ if (buffer.readableBytes() > 0) {
Review Comment:
I don't think we should change these.
Issue Time Tracking
-------------------
Worklog Id: (was: 909785)
Time Spent: 1.5h (was: 1h 20m)
> Add auto-create-destination logic to diverts
> --------------------------------------------
>
> Key: ARTEMIS-4510
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4510
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Anton Roskvist
> Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> This enables the use of dynamic routing decisions within the transformer by
> setting the message address. It also covers for a rare problem where if any
> of the forwarding addresses are removed during runtime, such as from
> auto-delete, the message would get silently dropped.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
