[
https://issues.apache.org/jira/browse/ARTEMIS-4510?focusedWorklogId=909858&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-909858
]
ASF GitHub Bot logged work on ARTEMIS-4510:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 14/Mar/24 10:11
Start Date: 14/Mar/24 10:11
Worklog Time Spent: 10m
Work Description: AntonRoskvist commented on code in PR #4681:
URL: https://github.com/apache/activemq-artemis/pull/4681#discussion_r1524585315
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/settings/impl/AddressSettings.java:
##########
@@ -1835,6 +1856,8 @@ public void encode(ActiveMQBuffer buffer) {
BufferHelper.writeNullableInteger(buffer, prefetchPageBytes);
BufferHelper.writeNullableInteger(buffer, prefetchPageMessages);
+
+ BufferHelper.writeNullableBoolean(buffer, autoCreateDivertDestination);
Review Comment:
@clebertsuconic Thanks, I have made the changes you suggested. The only
thing I'm noticing now is that if I inject this setting in some current
persistence tests they start failing, though I guess that might be expected
with this new method?
One example of a test that would fail is for instance:
`org.apache.activemq.artemis.tests.integration.persistence.AddressSettingsConfigurationStorageTest#testStoreSecuritySettings()`
where if I add some random previous address setting (like
`setAutoDeleteAddresses(true)`) the test still passes, whereas if I add
`setAutoCreateDivertDestination(true)` the test fails.
Is that right/expected or am I missing something?
Issue Time Tracking
-------------------
Worklog Id: (was: 909858)
Time Spent: 2h (was: 1h 50m)
> Add auto-create-destination logic to diverts
> --------------------------------------------
>
> Key: ARTEMIS-4510
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4510
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Anton Roskvist
> Priority: Major
> Time Spent: 2h
> Remaining Estimate: 0h
>
> This enables the use of dynamic routing decisions within the transformer by
> setting the message address. It also covers for a rare problem where if any
> of the forwarding addresses are removed during runtime, such as from
> auto-delete, the message would get silently dropped.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
