[
https://issues.apache.org/jira/browse/ARTEMIS-4668?focusedWorklogId=908190&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-908190
]
ASF GitHub Bot logged work on ARTEMIS-4668:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 04/Mar/24 23:23
Start Date: 04/Mar/24 23:23
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #4840:
URL: https://github.com/apache/activemq-artemis/pull/4840#discussion_r1511921835
##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/connect/AMQPBrokerConnection.java:
##########
@@ -847,6 +847,7 @@ public MessageWriter
selectOutgoingMessageWriter(ProtonServerSenderContext sende
if (message.isLargeMessage()) {
selected = largeMessageWriter != null ? largeMessageWriter :
(largeMessageWriter = new AMQPLargeMessageWriter(sender));
+ largeMessageWriter.openContext(reference);
Review Comment:
thing is.. it's always asynchronous... except to large messages... (since
the previous interaction already you had the current large message returning
something to make the handler return BUSY).
So.. in all the other cases it should be treating through the acceptor..
except to this large message case here.
Issue Time Tracking
-------------------
Worklog Id: (was: 908190)
Time Spent: 40m (was: 0.5h)
> Move AMQP Large Message File Handling away from Netty thread
> ------------------------------------------------------------
>
> Key: ARTEMIS-4668
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4668
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Affects Versions: 2.32.0
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Fix For: 2.33.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Operations like file.open, file.close, and file.sync should be moved away
> from the Netty Thread for AMQP Large Messages
> This task now is about moving the processing for AMQP Messages. we may in a
> near future also improve tunneled large messages. For now we will do for AMQP
> messages only.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
