[
https://issues.apache.org/jira/browse/ARTEMIS-4668?focusedWorklogId=908209&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-908209
]
ASF GitHub Bot logged work on ARTEMIS-4668:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 05/Mar/24 01:35
Start Date: 05/Mar/24 01:35
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #4840:
URL: https://github.com/apache/activemq-artemis/pull/4840#discussion_r1512013812
##########
artemis-protocols/artemis-amqp-protocol/src/test/java/org/apache/activemq/artemis/protocol/amqp/proton/AMQPTunneledCoreLargeMessageReaderTest.java:
##########
@@ -159,19 +169,18 @@ public void testReadMessageByteByByteFromDeliveryBuffer()
throws Exception {
when(receiver.recv()).thenReturn(deliveryAnnotations.duplicate().position(i -
1).limit(i).slice());
try {
- assertNull(reader.readBytes(delivery));
+ readMessage = null;
+ reader.readBytes(delivery);
+ Assert.assertNull(readMessage);
} catch (IllegalStateException e) {
fail("Should not throw as the reader should be able to read just
delivery annotations.");
}
}
- assertNotNull(reader.getDeliveryAnnotations());
-
- final DeliveryAnnotations annotations = reader.getDeliveryAnnotations();
-
- assertTrue(annotations.getValue().get(Symbol.valueOf("a")).equals("a"));
- assertTrue(annotations.getValue().get(Symbol.valueOf("b")).equals("b"));
- assertTrue(annotations.getValue().get(Symbol.valueOf("c")).equals("c"));
+ DeliveryAnnotations currentAnnotations = reader.getDeliveryAnnotations();
Review Comment:
@tabish121 I remembered what happened.. I tried removing the open method by
just the accept.. and I had made a mess back and forth until I stabilized on
what you saw...
thanks for the review.. I made the change.
Issue Time Tracking
-------------------
Worklog Id: (was: 908209)
Time Spent: 2h 10m (was: 2h)
> Move AMQP Large Message File Handling away from Netty thread
> ------------------------------------------------------------
>
> Key: ARTEMIS-4668
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4668
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Affects Versions: 2.32.0
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Fix For: 2.33.0
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> Operations like file.open, file.close, and file.sync should be moved away
> from the Netty Thread for AMQP Large Messages
> This task now is about moving the processing for AMQP Messages. we may in a
> near future also improve tunneled large messages. For now we will do for AMQP
> messages only.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
