[
https://issues.apache.org/jira/browse/ARTEMIS-4668?focusedWorklogId=908197&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-908197
]
ASF GitHub Bot logged work on ARTEMIS-4668:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 04/Mar/24 23:47
Start Date: 04/Mar/24 23:47
Worklog Time Spent: 10m
Work Description: tabish121 commented on code in PR #4840:
URL: https://github.com/apache/activemq-artemis/pull/4840#discussion_r1511948478
##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/connect/AMQPBrokerConnection.java:
##########
@@ -847,6 +847,7 @@ public MessageWriter
selectOutgoingMessageWriter(ProtonServerSenderContext sende
if (message.isLargeMessage()) {
selected = largeMessageWriter != null ? largeMessageWriter :
(largeMessageWriter = new AMQPLargeMessageWriter(sender));
+ largeMessageWriter.openContext(reference);
Review Comment:
I've made the change here locally and I don't see any reason it doesn't work
to just make the open method accept the message reference and do the
initialization there as opposed to adding a second "special" open method the
select of the writer is done in the same thread as the sender will be calling
open prior to handling the write into the connection thread.
Issue Time Tracking
-------------------
Worklog Id: (was: 908197)
Time Spent: 1h 40m (was: 1.5h)
> Move AMQP Large Message File Handling away from Netty thread
> ------------------------------------------------------------
>
> Key: ARTEMIS-4668
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4668
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Affects Versions: 2.32.0
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Fix For: 2.33.0
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Operations like file.open, file.close, and file.sync should be moved away
> from the Netty Thread for AMQP Large Messages
> This task now is about moving the processing for AMQP Messages. we may in a
> near future also improve tunneled large messages. For now we will do for AMQP
> messages only.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
