[
https://issues.apache.org/jira/browse/ARTEMIS-4582?focusedWorklogId=909163&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-909163
]
ASF GitHub Bot logged work on ARTEMIS-4582:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 11/Mar/24 11:19
Start Date: 11/Mar/24 11:19
Worklog Time Spent: 10m
Work Description: gtully commented on code in PR #4820:
URL: https://github.com/apache/activemq-artemis/pull/4820#discussion_r1519556299
##########
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/tools/xml/XmlDataImporter.java:
##########
@@ -337,17 +337,27 @@ private void sendMessage(List<String> queues, Message
message) throws Exception
logger.debug("Requesting ID for: {}", queue);
}
ClientMessage reply = requestor.request(managementMessage);
- Number idObject = (Number) ManagementHelper.getResult(reply);
- queueID = idObject.longValue();
+ if (ManagementHelper.hasOperationSucceeded(reply)) {
+ Number idObject = (Number) ManagementHelper.getResult(reply);
+ queueID = idObject.longValue();
+ } else {
+ if (debugLog) {
+ logger.debug("Failed to get ID for {} is: {}", queue,
ManagementHelper.getResult(reply, String.class));
+ }
Review Comment:
good catch, thanks. will fix.
Issue Time Tracking
-------------------
Worklog Id: (was: 909163)
Time Spent: 1h 40m (was: 1.5h)
> add view and update permissions to augment the manage rbac for control
> resources
> --------------------------------------------------------------------------------
>
> Key: ARTEMIS-4582
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4582
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker, Configuration, JMX, Web Console
> Affects Versions: 2.31.0
> Reporter: Gary Tully
> Assignee: Gary Tully
> Priority: Major
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> we have the manage permission that allows sending to the management address,
> to access any control resource. We don't however distinguish what a user can
> do.
> We should segment control operations into categories: CRUD provides a basis
> view for get/is (Read)
> update for set or operations that mutate or modify.
> We allow this sort of configuration via management.xml for jmx mbean access
> but using a different model based on object name.
> All of the mbeans delegate to the control resources.
> If we add these two additional permissions then we can have a single rbac
> model (that supports config reload) and more granularity on control resource
> access from the management address.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
