[ https://issues.apache.org/jira/browse/ARTEMIS-4582?focusedWorklogId=909202&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-909202 ]
ASF GitHub Bot logged work on ARTEMIS-4582: ------------------------------------------- Author: ASF GitHub Bot Created on: 11/Mar/24 13:19 Start Date: 11/Mar/24 13:19 Worklog Time Spent: 10m Work Description: gtully commented on code in PR #4820: URL: https://github.com/apache/activemq-artemis/pull/4820#discussion_r1519703742 ########## artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/LegacyLDAPSecuritySettingPlugin.java: ########## @@ -463,7 +463,9 @@ private void processSearchResult(Map<String, Set<Role>> securityRoles, mapAdminToManage ? admin : false, // manage - map to admin based on configuration read, // browse admin, // createAddress - admin); // deleteAddress + admin, // deleteAddress + read, // view + write); // edit Review Comment: thanks! Issue Time Tracking ------------------- Worklog Id: (was: 909202) Time Spent: 2h 50m (was: 2h 40m) > add view and update permissions to augment the manage rbac for control > resources > -------------------------------------------------------------------------------- > > Key: ARTEMIS-4582 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4582 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: Broker, Configuration, JMX, Web Console > Affects Versions: 2.31.0 > Reporter: Gary Tully > Assignee: Gary Tully > Priority: Major > Time Spent: 2h 50m > Remaining Estimate: 0h > > we have the manage permission that allows sending to the management address, > to access any control resource. We don't however distinguish what a user can > do. > We should segment control operations into categories: CRUD provides a basis > view for get/is (Read) > update for set or operations that mutate or modify. > We allow this sort of configuration via management.xml for jmx mbean access > but using a different model based on object name. > All of the mbeans delegate to the control resources. > If we add these two additional permissions then we can have a single rbac > model (that supports config reload) and more granularity on control resource > access from the management address. -- This message was sent by Atlassian Jira (v8.20.10#820010)