[
https://issues.apache.org/jira/browse/ARTEMIS-4582?focusedWorklogId=909204&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-909204
]
ASF GitHub Bot logged work on ARTEMIS-4582:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 11/Mar/24 13:23
Start Date: 11/Mar/24 13:23
Worklog Time Spent: 10m
Work Description: gtully commented on code in PR #4820:
URL: https://github.com/apache/activemq-artemis/pull/4820#discussion_r1519711041
##########
artemis-server/src/test/java/org/apache/activemq/artemis/core/security/RoleTest.java:
##########
@@ -91,12 +91,12 @@ public void testManageRole() throws Exception {
@Test
public void testEqualsAndHashcode() throws Exception {
- Role role = new Role("testEquals", true, true, true, false, false,
false, false, false, false, false);
- Role sameRole = new Role("testEquals", true, true, true, false, false,
false, false, false, false, false);
- Role roleWithDifferentName = new Role("notEquals", true, true, true,
false, false, false, false, false, false, false);
- Role roleWithDifferentRead = new Role("testEquals", false, true, true,
false, false, false, false, false, false, false);
- Role roleWithDifferentWrite = new Role("testEquals", true, false, true,
false, false, false, false, false, false, false);
- Role roleWithDifferentCreate = new Role("testEquals", true, true, false,
false, false, false, false, false, false, false);
+ Role role = new Role("testEquals", true, true, true, false, false,
false, false, false, false, false, false, false);
+ Role sameRole = new Role("testEquals", true, true, true, false, false,
false, false, false, false, false, false, false);
+ Role roleWithDifferentName = new Role("notEquals", true, true, true,
false, false, false, false, false, false, false, false, false);
+ Role roleWithDifferentRead = new Role("testEquals", false, true, true,
false, false, false, false, false, false, false, false, false);
+ Role roleWithDifferentWrite = new Role("testEquals", true, false, true,
false, false, false, false, false, false, false, false, false);
+ Role roleWithDifferentCreate = new Role("testEquals", true, true, false,
false, false, false, false, false, false, false, false, false);
Review Comment:
good catch, thanks :-)
Issue Time Tracking
-------------------
Worklog Id: (was: 909204)
Time Spent: 3h (was: 2h 50m)
> add view and update permissions to augment the manage rbac for control
> resources
> --------------------------------------------------------------------------------
>
> Key: ARTEMIS-4582
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4582
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker, Configuration, JMX, Web Console
> Affects Versions: 2.31.0
> Reporter: Gary Tully
> Assignee: Gary Tully
> Priority: Major
> Time Spent: 3h
> Remaining Estimate: 0h
>
> we have the manage permission that allows sending to the management address,
> to access any control resource. We don't however distinguish what a user can
> do.
> We should segment control operations into categories: CRUD provides a basis
> view for get/is (Read)
> update for set or operations that mutate or modify.
> We allow this sort of configuration via management.xml for jmx mbean access
> but using a different model based on object name.
> All of the mbeans delegate to the control resources.
> If we add these two additional permissions then we can have a single rbac
> model (that supports config reload) and more granularity on control resource
> access from the management address.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
