[
https://issues.apache.org/jira/browse/ARTEMIS-4924?focusedWorklogId=927242&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-927242
]
ASF GitHub Bot logged work on ARTEMIS-4924:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 24/Jul/24 15:05
Start Date: 24/Jul/24 15:05
Worklog Time Spent: 10m
Work Description: gaohoward commented on code in PR #5091:
URL: https://github.com/apache/activemq-artemis/pull/5091#discussion_r1689986457
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/impl/ClusterConnectionBridge.java:
##########
@@ -201,12 +201,6 @@ protected Message beforeForward(final Message message,
final SimpleString forwar
byte[] queueIds = message.getExtraBytesProperty(idsHeaderName);
- if (queueIds == null) {
- // Sanity check only
- ActiveMQServerLogger.LOGGER.noQueueIdDefined(message, messageCopy,
idsHeaderName);
Review Comment:
I think it would be better to check before it enters the queue, by this time
it is too late.
Issue Time Tracking
-------------------
Worklog Id: (was: 927242)
Time Spent: 1h 10m (was: 1h)
> Do not allow sending messages directly to store-and-forward queues
> ------------------------------------------------------------------
>
> Key: ARTEMIS-4924
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4924
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Clustering
> Affects Versions: 2.35.0
> Reporter: Howard Gao
> Assignee: Howard Gao
> Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Currently, if a poison message missing queue information ends up in the SF
> queue, the broker logs an error, like:
> AMQ222110: no queue IDs defined...
> but the message remains in the queue, with the result that the bridge
> continuously reconnects, encounters the failure, then evicts the bridge
> consumer.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
