[
https://issues.apache.org/jira/browse/ARTEMIS-4924?focusedWorklogId=927246&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-927246
]
ASF GitHub Bot logged work on ARTEMIS-4924:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 24/Jul/24 15:12
Start Date: 24/Jul/24 15:12
Worklog Time Spent: 10m
Work Description: gaohoward commented on code in PR #5091:
URL: https://github.com/apache/activemq-artemis/pull/5091#discussion_r1689998704
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java:
##########
@@ -1284,6 +1284,15 @@ public void addTail(final MessageReference ref, final
boolean direct) {
if (scheduleIfPossible(ref)) {
return;
}
+ if (checkInvalid(ref)) {
+ //send to dlq
+ try {
+ sendToDeadLetterAddress(null, ref);
Review Comment:
I think that's the simple way to go. The message should be checked before it
goes into queue. By the time it goes to deliver process, it's too late I think.
But adding a header perhaps to tell the reason makes sense to me.
Issue Time Tracking
-------------------
Worklog Id: (was: 927246)
Time Spent: 1.5h (was: 1h 20m)
> Do not allow sending messages directly to store-and-forward queues
> ------------------------------------------------------------------
>
> Key: ARTEMIS-4924
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4924
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Clustering
> Affects Versions: 2.35.0
> Reporter: Howard Gao
> Assignee: Howard Gao
> Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Currently, if a poison message missing queue information ends up in the SF
> queue, the broker logs an error, like:
> AMQ222110: no queue IDs defined...
> but the message remains in the queue, with the result that the bridge
> continuously reconnects, encounters the failure, then evicts the bridge
> consumer.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
