[
https://issues.apache.org/jira/browse/ARTEMIS-4924?focusedWorklogId=927264&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-927264
]
ASF GitHub Bot logged work on ARTEMIS-4924:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 24/Jul/24 16:19
Start Date: 24/Jul/24 16:19
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #5091:
URL: https://github.com/apache/activemq-artemis/pull/5091#discussion_r1690102571
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/impl/ClusterConnectionImpl.java:
##########
@@ -712,6 +712,19 @@ private synchronized void activate() throws Exception {
serverLocator.start(server.getExecutorFactory().getExecutor());
}
+ // add security role to disallow send/edit directly to sf queues
+ if (server.getConfiguration().isSecurityEnabled()) {
+ Set<Role> roles = new HashSet<>();
+ String addressMatch = storeAndForwardPrefix + name + "." +
server.getConfiguration().getWildcardConfiguration().getSingleWordString();
Review Comment:
@gtully I was going to merge it now.. but it seems you still have some
things to discuss on this one.
i will skip this one from the next apache artemis release I'm doing... it
will be in the next one.
Issue Time Tracking
-------------------
Worklog Id: (was: 927264)
Time Spent: 1h 40m (was: 1.5h)
> Do not allow sending messages directly to store-and-forward queues
> ------------------------------------------------------------------
>
> Key: ARTEMIS-4924
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4924
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Clustering
> Affects Versions: 2.35.0
> Reporter: Howard Gao
> Assignee: Howard Gao
> Priority: Major
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Currently, if a poison message missing queue information ends up in the SF
> queue, the broker logs an error, like:
> AMQ222110: no queue IDs defined...
> but the message remains in the queue, with the result that the bridge
> continuously reconnects, encounters the failure, then evicts the bridge
> consumer.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
