[
https://issues.apache.org/jira/browse/ARTEMIS-5037?focusedWorklogId=936748&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-936748
]
ASF GitHub Bot logged work on ARTEMIS-5037:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 27/Sep/24 09:11
Start Date: 27/Sep/24 09:11
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #5220:
URL: https://github.com/apache/activemq-artemis/pull/5220#discussion_r1778266549
##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/connect/mirror/AMQPMirrorControllerSource.java:
##########
@@ -236,6 +238,10 @@ public void deleteAddress(AddressInfo addressInfo) throws
Exception {
if (ignoreAddress(addressInfo.getName())) {
return;
}
+ if (isBlockedByNoForward()) {
+ return;
+ }
+
Review Comment:
I would do this earlier; no point checking the specific address is permitted
(the bit above) if we aren't allowed to forward it _anywhere_.
Same for other bits further down
Issue Time Tracking
-------------------
Worklog Id: (was: 936748)
Time Spent: 3.5h (was: 3h 20m)
> AMQ Broker Mirroring: One to Many - avoid the infinite loop of the messages
> ---------------------------------------------------------------------------
>
> Key: ARTEMIS-5037
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5037
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: Thomas Lavocat
> Assignee: Thomas Lavocat
> Priority: Major
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> AMQ Broker Mirroring: One to Many - avoid the infinite loop of the messages:
> if we have a->b-c->a..
> a message will circulate forever in the mirrors
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
