[
https://issues.apache.org/jira/browse/ARTEMIS-5037?focusedWorklogId=945661&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-945661
]
ASF GitHub Bot logged work on ARTEMIS-5037:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 26/Nov/24 09:03
Start Date: 26/Nov/24 09:03
Worklog Time Spent: 10m
Work Description: lavocatt commented on code in PR #5220:
URL: https://github.com/apache/activemq-artemis/pull/5220#discussion_r1858083927
##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/connect/mirror/AMQPMirrorControllerSource.java:
##########
@@ -559,6 +587,10 @@ public void preAcknowledge(final Transaction tx, final
MessageReference ref, fin
return;
}
+ if (isBlockedByNoForward()) {
+ return;
+ }
+
Review Comment:
I believe this is addressed now, feel free to reopen if you catch a mistake.
Issue Time Tracking
-------------------
Worklog Id: (was: 945661)
Time Spent: 4h 10m (was: 4h)
> AMQ Broker Mirroring: One to Many - avoid the infinite loop of the messages
> ---------------------------------------------------------------------------
>
> Key: ARTEMIS-5037
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5037
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: Thomas Lavocat
> Assignee: Thomas Lavocat
> Priority: Major
> Labels: pull-request-available
> Time Spent: 4h 10m
> Remaining Estimate: 0h
>
> AMQ Broker Mirroring: One to Many - avoid the infinite loop of the messages:
> if we have a->b-c->a..
> a message will circulate forever in the mirrors
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
