[
https://issues.apache.org/jira/browse/ARTEMIS-5037?focusedWorklogId=946019&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-946019
]
ASF GitHub Bot logged work on ARTEMIS-5037:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 28/Nov/24 14:08
Start Date: 28/Nov/24 14:08
Worklog Time Spent: 10m
Work Description: lavocatt commented on code in PR #5220:
URL: https://github.com/apache/activemq-artemis/pull/5220#discussion_r1862262144
##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/connect/mirror/AMQPMirrorControllerSource.java:
##########
@@ -89,9 +90,15 @@ public class AMQPMirrorControllerSource extends
BasicMirrorController<Sender> im
// Capabilities
public static final Symbol MIRROR_CAPABILITY =
Symbol.getSymbol("amq.mirror");
public static final Symbol QPID_DISPATCH_WAYPOINT_CAPABILITY =
Symbol.valueOf("qd.waypoint");
+ public static final Symbol NO_FORWARD = Symbol.getSymbol("amq.no.forward");
+ public static final Symbol NO_FORWARD_SOURCE =
Symbol.getSymbol("amq.no.forward.source");
+ public static final Symbol RECEIVER_ID_FILTER =
Symbol.getSymbol("amq.receiver.id.filter");
Review Comment:
The NO_FORWARD_SOURCE is used as a BrokerProperty which is and that requires
to have a Symbol passed as a parameter:

Issue Time Tracking
-------------------
Worklog Id: (was: 946019)
Time Spent: 5h 10m (was: 5h)
> AMQ Broker Mirroring: One to Many - avoid the infinite loop of the messages
> ---------------------------------------------------------------------------
>
> Key: ARTEMIS-5037
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5037
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: Thomas Lavocat
> Assignee: Thomas Lavocat
> Priority: Major
> Labels: pull-request-available
> Time Spent: 5h 10m
> Remaining Estimate: 0h
>
> AMQ Broker Mirroring: One to Many - avoid the infinite loop of the messages:
> if we have a->b-c->a..
> a message will circulate forever in the mirrors
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact