[
https://issues.apache.org/jira/browse/ARTEMIS-5155?focusedWorklogId=943959&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-943959
]
ASF GitHub Bot logged work on ARTEMIS-5155:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 15/Nov/24 16:48
Start Date: 15/Nov/24 16:48
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on PR #5346:
URL:
https://github.com/apache/activemq-artemis/pull/5346#issuecomment-2479417656
this change is reverting the offending change from
c83ed8957d9d7f06bb29c0fce563fe2e3462993e
As I said before, marking the LargeMessageReader as complete after the
delivery of the message of the queue could cause the message body to go
truncated, if a network failure happened between the delivery and the actual
close of the message (aka race).
I'm merging this PR now as this is clearly an issue and this fixes that
issue.
Issue Time Tracking
-------------------
Worklog Id: (was: 943959)
Time Spent: 20m (was: 10m)
> AMQP LargeMessage file should be closed before calling advance
> --------------------------------------------------------------
>
> Key: ARTEMIS-5155
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5155
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Affects Versions: 2.38.0
> Reporter: Clebert Suconic
> Priority: Major
> Labels: pull-request-available
> Fix For: 2.39.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> This is to fix tests in LargeMessageInterruptTest.
> When sending a large message the file should be closed before calling advance
> and performing further storage operations.
> This is regressed after
> c83ed8957d9d7f06bb29c0fce563fe2e3462993e / ARTEMIS-4668
> Where the file.close was moved to the finalize block after the delivery...
> causing a possible race over a server's failure.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
