[ 
https://issues.apache.org/jira/browse/ARTEMIS-5155?focusedWorklogId=943968&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-943968
 ]

ASF GitHub Bot logged work on ARTEMIS-5155:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 15/Nov/24 17:43
            Start Date: 15/Nov/24 17:43
    Worklog Time Spent: 10m 
      Work Description: clebertsuconic commented on PR #5346:
URL: 
https://github.com/apache/activemq-artemis/pull/5346#issuecomment-2479577575

   @gemmellr  all I'm fixing now is.. when closeCurrentReader is called, it's 
deleting the file...
   
   
   which is what I'm fixing.. if you want to improve other things in large 
message.. it's totally orthogonal to this.. this change is fixing the issue.
   




Issue Time Tracking
-------------------

    Worklog Id:     (was: 943968)
    Time Spent: 50m  (was: 40m)

> AMQP LargeMessage file should be closed before calling advance
> --------------------------------------------------------------
>
>                 Key: ARTEMIS-5155
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-5155
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>    Affects Versions: 2.38.0
>            Reporter: Clebert Suconic
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 2.39.0
>
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> This is to fix tests in LargeMessageInterruptTest.
> When sending a large message the file should be closed before calling advance 
> and performing further storage operations.
> This is regressed after 
> c83ed8957d9d7f06bb29c0fce563fe2e3462993e /  ARTEMIS-4668
> Where the file.close was moved to the finalize block after the delivery... 
> causing a possible race over a server's failure.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact


Reply via email to