[
https://issues.apache.org/jira/browse/ARTEMIS-5155?focusedWorklogId=943961&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-943961
]
ASF GitHub Bot logged work on ARTEMIS-5155:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 15/Nov/24 17:02
Start Date: 15/Nov/24 17:02
Worklog Time Spent: 10m
Work Description: gemmellr commented on PR #5346:
URL:
https://github.com/apache/activemq-artemis/pull/5346#issuecomment-2479445995
I changed it to draft, as we have been looking into why this change might
have any effect, as it didnt seem to either myself or Tim that it should have
the desired impact, and possibly pointed to a potential concurrency problem.
Whilst moving this might indeed help adjust the behaviour to stop a test
failing, it still isnt clear to either of us it is actually the correct change
given the point the close is done. Tim may have found a related issue around
the delivery handling offloading large messages to another thread.
In short, we still need to look at this a bit closer before merging.
Issue Time Tracking
-------------------
Worklog Id: (was: 943961)
Time Spent: 0.5h (was: 20m)
> AMQP LargeMessage file should be closed before calling advance
> --------------------------------------------------------------
>
> Key: ARTEMIS-5155
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5155
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Affects Versions: 2.38.0
> Reporter: Clebert Suconic
> Priority: Major
> Labels: pull-request-available
> Fix For: 2.39.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> This is to fix tests in LargeMessageInterruptTest.
> When sending a large message the file should be closed before calling advance
> and performing further storage operations.
> This is regressed after
> c83ed8957d9d7f06bb29c0fce563fe2e3462993e / ARTEMIS-4668
> Where the file.close was moved to the finalize block after the delivery...
> causing a possible race over a server's failure.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
