[
https://issues.apache.org/jira/browse/ARTEMIS-5168?focusedWorklogId=944825&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-944825
]
ASF GitHub Bot logged work on ARTEMIS-5168:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 21/Nov/24 12:20
Start Date: 21/Nov/24 12:20
Worklog Time Spent: 10m
Work Description: gemmellr commented on PR #5359:
URL:
https://github.com/apache/activemq-artemis/pull/5359#issuecomment-2490991954
Thinking that @clebertsuconic meant to post these comments here instead of
#5363:
https://github.com/apache/activemq-artemis/pull/5363#issuecomment-2489998018
> I really liked this...
>
> can I ask a small change.. if you can't do it.. I will do it later...
>
> if the user is null.. just don't set the user
>
> If I have a broker without an user (anonymous user).. it's currently
showing null@tcp://localhost:61616 >
>
> I think it should use just tcp://localhost:61616 >
>
> although the check that you have on the Exception would need to be
different.. perhaps just use a boolean to connected instead.
https://github.com/apache/activemq-artemis/pull/5363#issuecomment-2489998328
> It's currently showing this, when null:
>
> null@tcp://localhost:61616 >
Issue Time Tracking
-------------------
Worklog Id: (was: 944825)
Time Spent: 20m (was: 10m)
> Improve remoting to brokers from Artemis shell
> ----------------------------------------------
>
> Key: ARTEMIS-5168
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5168
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Anton Roskvist
> Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Add back connect + disconnect to shell
> Change prompt to reflect if it's connected to a broker
> Ctrl + D will return to shell if issued when connected to a broker
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
