[ 
https://issues.apache.org/jira/browse/ARTEMIS-5168?focusedWorklogId=944841&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-944841
 ]

ASF GitHub Bot logged work on ARTEMIS-5168:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 21/Nov/24 13:03
            Start Date: 21/Nov/24 13:03
    Worklog Time Spent: 10m 
      Work Description: AntonRoskvist commented on PR #5359:
URL: 
https://github.com/apache/activemq-artemis/pull/5359#issuecomment-2491091514

   Thanks @gemmellr 
   
   @clebertsuconic I actually had it slightly differently at one point where I 
set the user as "anonymous@tcp://..." referencing "--allow-anonymous" from the 
create command. I opted against it because just prior the shell will log this:
   `getActionContext().out.println("CLI connected to broker " + brokerURL + ", 
user:" + user);`
   
   I can go with either but I feel like that logging should be consistent and 
also log "user: anonymous" or no user at all.
   
   I am fine making the change either way but it might be a day or two before I 
can get to it (hectic schedule)




Issue Time Tracking
-------------------

    Worklog Id:     (was: 944841)
    Time Spent: 50m  (was: 40m)

> Improve remoting to brokers from Artemis shell
> ----------------------------------------------
>
>                 Key: ARTEMIS-5168
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-5168
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>            Reporter: Anton Roskvist
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> Add back connect + disconnect to shell
> Change prompt to reflect if it's connected to a broker
> Ctrl + D will return to shell if issued when connected to a broker



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact


Reply via email to