[
https://issues.apache.org/jira/browse/ARTEMIS-5168?focusedWorklogId=945169&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-945169
]
ASF GitHub Bot logged work on ARTEMIS-5168:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 22/Nov/24 14:14
Start Date: 22/Nov/24 14:14
Worklog Time Spent: 10m
Work Description: gemmellr commented on PR #5359:
URL:
https://github.com/apache/activemq-artemis/pull/5359#issuecomment-2493863040
> @clebertsuconic @gemmellr Hope these changes are to your liking.
>
> For a future change I've also looked a bit into adding [command
history](https://github.com/jline/jline3/wiki/History) Not really sure how to
verify that properly though as I have no access to a Windows PC, but I think it
should be fairly trivial to implement.
>
> Finally I'd also be interested in building this as a standalone tool and
distribute it on the website, alongside the broker distribution and the native
binaries.
>
> I've build this for my own purposes with `maven-assembly-plugin` added to
the [artemis-cli](https://issues.apache.org/jira/browse/ARTEMIS-cli)/pom.xml
but I suspect that might not be the best way to do it as part of building the
project in its entirety. I also don't really know if just a jar file is "fine"
to distribute or if we want additional packaging to make the tool as intuitive
and user friendly as possible.
>
> Do you have any thoughts on this?
I wouldn't be in favour of it personally. The CLI already depends on a large
proportion of the broker distribution so there would be a significant overlap.
Given the way they exist in the overall build and are typically used, the
benefits of a standalone CLI distribution relly dont seem that significant to
me to warrant actually maintaining such a thing. Some uses actively dont seem
to make sense given their relation to the broker / instance configuration.
Which makes me think..have I actually entirely misunderstood what you are
asking about?
The native bits for the journal only have their own downloads because they
are actually released independently, infrequently, and so requires its own
source assembly (the source is always the 'actual release'). The convenience
binary is only there because its being built so the output can be consumed in
the actual broker convenience binaries later during Artemis builds. Its off on
its own sub-download page without any wider site component detail since its not
really expected anyone actually needs to download it.
Thoughts of a 'new' component distribution would also really be for
discussion on the mailing list, rather than just a simple improvement PR.
Issue Time Tracking
-------------------
Worklog Id: (was: 945169)
Time Spent: 1h 50m (was: 1h 40m)
> Improve remoting to brokers from Artemis shell
> ----------------------------------------------
>
> Key: ARTEMIS-5168
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5168
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Anton Roskvist
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Add back connect + disconnect to shell
> Change prompt to reflect if it's connected to a broker
> Ctrl + D will return to shell if issued when connected to a broker
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
