[
https://issues.apache.org/jira/browse/AMQ-9478?focusedWorklogId=946927&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-946927
]
ASF GitHub Bot logged work on AMQ-9478:
---------------------------------------
Author: ASF GitHub Bot
Created on: 05/Dec/24 20:16
Start Date: 05/Dec/24 20:16
Worklog Time Spent: 10m
Work Description: pa-deasy opened a new pull request, #1360:
URL: https://github.com/apache/activemq/pull/1360
**What problems does this PR solve?**
Add test coverage to ensure socket parameters can be set for tcp and ssl
connections.
**Why is it beneficial to merge into ActiveMQ?**
The tests provide confidence and prevent future issues like
[AMQ-9473](https://issues.apache.org/jira/browse/AMQ-9473).
**How do you make sure this PR is well tested?**
_Test A_
Ran the two new units tests and verified success.
_Test B_
Edited the `IntrospectionSupport` class to comment out the following:
```
// if (target instanceof SSLServerSocket) {
// // overcome illegal access issues with internal
implementation class
// clazz = SSLServerSocket.class;
// } else if (target instanceof javax.net.ssl.SSLSocket) {
// // overcome illegal access issues with internal
implementation class
// clazz = javax.net.ssl.SSLSocket.class;
// }
```
Ran the two new units tests and verified failure due to
`java.lang.IllegalArgumentException: Invalid socket parameters`.
Issue Time Tracking
-------------------
Worklog Id: (was: 946927)
Remaining Estimate: 0h
Time Spent: 10m
> Add unit test for modernized IntrospectionSupport
> -------------------------------------------------
>
> Key: AMQ-9478
> URL: https://issues.apache.org/jira/browse/AMQ-9478
> Project: ActiveMQ Classic
> Issue Type: Task
> Reporter: Matt Pavlovich
> Assignee: Jean-Baptiste Onofré
> Priority: Minor
> Fix For: 6.2.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Update unit test to verify transport connector and network connector uri
> handling for
> IntrospectionSupport to deal with TcpSocket properties
> IntrospectionSupport to deal with SSLSocket properties
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
