[
https://issues.apache.org/jira/browse/AMQ-9478?focusedWorklogId=947292&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-947292
]
ASF GitHub Bot logged work on AMQ-9478:
---------------------------------------
Author: ASF GitHub Bot
Created on: 09/Dec/24 12:44
Start Date: 09/Dec/24 12:44
Worklog Time Spent: 10m
Work Description: cshannon commented on code in PR #1360:
URL: https://github.com/apache/activemq/pull/1360#discussion_r1875923956
##########
activemq-unit-tests/src/test/java/org/apache/activemq/ActiveMQSslConnectionFactoryTest.java:
##########
@@ -72,6 +81,34 @@ public void testCreateTcpConnectionUsingKnownPort() throws
Exception {
brokerStop();
}
+ public void testCreateTcpConnectionWithSocketParameters() throws Exception
{
+ // Control case: check that the factory can create an ordinary
(non-ssl) connection.
+ String tcpUri =
"tcp://localhost:61610?socket.OOBInline=true&socket.keepAlive=true&tcpNoDelay=true";
+ broker = createBroker(tcpUri);
+
+ // This should create the connection.
+ ActiveMQSslConnectionFactory cf = getFactory(tcpUri);
+ connection = (ActiveMQConnection)cf.createConnection();
+ assertNotNull(connection);
+
+ Transport transport = connection.getTransport();
Review Comment:
All of this code to get the socket is copied and pasted twice in both tests
so you should move it into a helper method so it can be re-used. It might even
come in handy as a utility for use in other tests as well but for now just
making it a helper method for this test is ok just so it's not duplicated.
Issue Time Tracking
-------------------
Worklog Id: (was: 947292)
Time Spent: 1h 20m (was: 1h 10m)
> Add unit test for modernized IntrospectionSupport
> -------------------------------------------------
>
> Key: AMQ-9478
> URL: https://issues.apache.org/jira/browse/AMQ-9478
> Project: ActiveMQ Classic
> Issue Type: Task
> Reporter: Matt Pavlovich
> Assignee: Jean-Baptiste Onofré
> Priority: Minor
> Fix For: 6.2.0
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Update unit test to verify transport connector and network connector uri
> handling for
> IntrospectionSupport to deal with TcpSocket properties
> IntrospectionSupport to deal with SSLSocket properties
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
