[
https://issues.apache.org/jira/browse/AMQ-9478?focusedWorklogId=947090&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-947090
]
ASF GitHub Bot logged work on AMQ-9478:
---------------------------------------
Author: ASF GitHub Bot
Created on: 06/Dec/24 17:50
Start Date: 06/Dec/24 17:50
Worklog Time Spent: 10m
Work Description: pa-deasy commented on PR #1360:
URL: https://github.com/apache/activemq/pull/1360#issuecomment-2523848783
> This is a good start but I think the tests could be improved. The tests
show there is no more exception on connection creation which is good, but it
would be nice to try setting more than one parameter and also if it's possible
to access it would be good to verify the settings worked. For example, the one
test sets the the ssl enabled protocols to TLSv1.3 so it would be best to
assert that it did in fact apply that setting.
That's a good suggestion, I've added more parameters to the unit tests. I
tried verifying the parameters are in effect but it's a little difficult
without exposing the `protected` `Socket` on the `TcpTransport`. I tried
researching a bunch of libraries that might check the TLS version on a TCP
capture but it didn't really work and would also have introduced an extra
dependency. Do you have any suggestions on a better approach for verifying the
socket changes? A lot of the logic resides in the JVM so it's difficult to
verify.
Issue Time Tracking
-------------------
Worklog Id: (was: 947090)
Time Spent: 50m (was: 40m)
> Add unit test for modernized IntrospectionSupport
> -------------------------------------------------
>
> Key: AMQ-9478
> URL: https://issues.apache.org/jira/browse/AMQ-9478
> Project: ActiveMQ Classic
> Issue Type: Task
> Reporter: Matt Pavlovich
> Assignee: Jean-Baptiste Onofré
> Priority: Minor
> Fix For: 6.2.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Update unit test to verify transport connector and network connector uri
> handling for
> IntrospectionSupport to deal with TcpSocket properties
> IntrospectionSupport to deal with SSLSocket properties
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
