[
https://issues.apache.org/jira/browse/AMQ-9646?focusedWorklogId=953990&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-953990
]
ASF GitHub Bot logged work on AMQ-9646:
---------------------------------------
Author: ASF GitHub Bot
Created on: 23/Jan/25 23:37
Start Date: 23/Jan/25 23:37
Worklog Time Spent: 10m
Work Description: cshannon commented on PR #1377:
URL: https://github.com/apache/activemq/pull/1377#issuecomment-2611230540
I only started looking at this but one thing I wanted to point out that
could be changed as part of this and something I missed before when #1258 was
done.... instead of having a position counter and having to scan through
couldn't you just set the batch for recovery at the offset location? Also, the
offset should probably be a long and not an int because long is used by the
order index.
I haven't tested it super well other than running the
KahaDBOffsetRecoveryListenerTest, but here is an example against the main
branch of what I mean:
https://github.com/cshannon/activemq/commit/648a580c2134209280a7b6dccd24fb718ee8457f
The other impls (temp kaha, memory) may be able to be changed too, not sure.
Issue Time Tracking
-------------------
Worklog Id: (was: 953990)
Time Spent: 50m (was: 40m)
> Support selecting specific messages for command line backup
> -----------------------------------------------------------
>
> Key: AMQ-9646
> URL: https://issues.apache.org/jira/browse/AMQ-9646
> Project: ActiveMQ Classic
> Issue Type: Improvement
> Reporter: Matt Pavlovich
> Assignee: Matt Pavlovich
> Priority: Minor
> Fix For: 6.2.0, 5.19.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
